-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcoh_view
: fix mintpy.utils.arg_utils
import
#101
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR addresses an import error by updating the module references from Class diagram for updated argument parser setupclassDiagram
class ArgUtils {
+add_timefunc_argument(parser)
+add_data_disp_argument(parser)
+add_dem_argument(parser)
+add_figure_argument(parser)
+add_gps_argument(parser)
+add_mask_argument(parser)
+add_map_argument(parser)
+add_memory_argument(parser)
+add_reference_argument(parser)
+add_save_argument(parser)
+add_subset_argument(parser)
}
class TcohView {
+create_parser()
}
TcohView --> ArgUtils : uses
note for ArgUtils "Methods previously accessed via arg_group are now accessed via arg_utils"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yunjunz - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR summaryThis Pull Request addresses two main issues: it fixes an import error in the SuggestionConsider adding a test case to verify that the import issue is resolved and that the Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect. Current plan usage: 0.00% Have feedback or need help? |
This PR does the following:
mintpy.utils.arg_utils
import error (tcoh_view.py not working #100) intcoh.view.py
README.md
, instead of manually updating it for each releaseSummary by Sourcery
Fix the import error in 'tcoh_view.py' by using 'arg_utils' instead of 'arg_group' for function calls, and update the version badge in 'README.md' to dynamically display the latest release version.
Bug Fixes:
Enhancements: